mail() script problem

Codewalkers Forums Sponsor:

AT&T devCentral & BlackBerry(r) Webcast Series: BlackBerry and GPS -Build Location Awareness into your BlackBerry Applications, July 10th-1:00PM EST. Register Today!

May 30th, 2002, 11:45 AM

D1NGO

Join Date: Apr 2007

Location: Perth, Australia

Posts: 221

Time spent in forums: < 1 sec
Reputation Power: 2

mail() script problem

Hey folks, i'm having trouble with my feedback form thing, this is my script

php Code:

Original - php Code
<?php $var1 = {$_POST['topic']}; $var2 = {$_POST['message']}; $var3 = {$_POST['name']}; $to = '"Admin" <me@mydomain.net>'; $from = 'From: "$var3" <me@mydomain.com>'; $subject = '$var1'; $message = '$var2'; mail($to,$subject,$message,$from); echo 'Feedback Sent <a href="index.php">Return to Site</a>'; ?>

 
<?php
 
$var1 = {$_POST['topic']};
$var2 = {$_POST['message']};
$var3 = {$_POST['name']};
 
$to = '"Admin" <me@mydomain.net>';
$from = 'From: "$var3" <me@mydomain.com>';
$subject = '$var1';
$message = '$var2';
 
mail($to,$subject,$message,$from);
echo 'Feedback Sent <a href="index.php">Return to Site</a>';
 
?>

this works if there are no variables used, but as soon as i throw in some variables from the previous page it gives me a parse error, any suggestions?

May 30th, 2002, 04:13 PM

Matt

Moderator

Codewalkers Specialist (4000 - 4499 posts)

Join Date: Apr 2007

Location: Florida

Posts: 4,158

Time spent in forums: 4 h 10 m 20 sec
Reputation Power: 6

RE: mail() script problem

PHP does not do variable substitution within single quotes, so this:

$from = 'From: "$var3" <me@mydomain.com>';
$subject = '$var1';
$message = '$var2';

neeeds to be :

$from = "From: "$var3" <me@mydomain.com>";
$subject = "$var1";
$message = "$var2";

May 30th, 2002, 04:53 PM

D1NGO

Join Date: Apr 2007

Location: Perth, Australia

Posts: 221

Time spent in forums: < 1 sec
Reputation Power: 2

RE: mail() script problem

thanks mate, cant believe i didnt notice that..lol

Viewing: Codewalkers Forums > PHP Related > PHP Coding > mail() script problem

« Previous Thread | Next Thread »

Thread Tools	Search this Thread
Email this Page	Search this Thread: Advanced Search
Display Modes	Rate This Thread
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode	Rate This Thread:

Posting Rules
You may not post new threads You may not post replies You may not post attachments You may not edit your posts vB code is On Smilies are On [IMG] code is On HTML code is Off

View Your Warnings | New Posts | Latest News | Latest Threads | Shoutbox

Forum Jump