Help 2 Optmize This Script!

Codewalkers Forums Sponsor:

April 12th, 2005, 08:33 PM

rApid

Join Date: Apr 2007

Posts: 1

Time spent in forums: < 1 sec
Reputation Power: 0

Help 2 Optmize This Script!

I know people say using print rather then echo, and things like object instead of array is faster, but could someone please take this console script, and optmize it as fast as it can be made, by using print and object, and other things to make load times as fast as possible.

php Code:

Original - php Code

 
 function dispConsole()
{
         global $row1, $row2, $bgimg, $consolesep;
 
         {
        dispProfile();
echo ' Welcome to Your Console '.$_SESSION['rank'].' '.$_SESSION['username'].'
        ';
$result1=mysql_query("SELECT * FROM consoles WHERE minrank<= '".$_SESSION['rank']."' AND disabled=0  ORDER BY position ASC");
 while($row2 = mysql_fetch_object($result1)) {
 
 
                echo '
                <div align='center'>
         <table width=85%>
          <tr class='row1'>';
           echo "<td background=$bgimg width=75%>";echo '<u>'.$GLOBALS['consolecolor'].' '; echo " $row2->name "; echo ' </font></u></td>
          </tr>
          <tr class='row2'>
            <td align='center'>
';
 
 
 $result = mysql_query("SELECT * FROM consolestuff WHERE minrank<= '".$_SESSION['rank']."' AND console ="$row2->name"");
 
 while($row3 = mysql_fetch_object($result)) {
 
echo " $consolesep <a href=$row3->link> $row3->name</a> "; } echo '   $consolesep
  </td>
          </tr>
        </table>
        </div>
     ';
     //viewNews(1);
}        } }

any help would be great, i would like to see how some of you code compared to me, and if it is a faster way of coding the same script, i'd love to use your way instead!

April 12th, 2005, 08:44 PM

System

Join Date: Apr 2007

Posts: 665

Time spent in forums: < 1 sec
Reputation Power: 3

Message Moved

Thread moved from 'PHP Coding' to 'Programming Theory' by andrew.

Reason:

April 12th, 2005, 10:58 PM

lig

"Forum Nazi"

Join Date: Apr 2007

Location: Jacksonville, Fl

Posts: 4,775

Time spent in forums: 4 Days 13 h 47 m 18 sec
Reputation Power: 7

RE: Help 2 Optmize This Script!

As far as I know echo vs. print has little to no difference in speed. Arrays vs. Objects = As far as I know they are also reletively comparitable - though I beleive arrays take up less space (don't bet the farm on that though).

One thing I did notice is that you use double quotes occasionally. singles are faster. Also you echo out HTML - you can just open and close your php instead, especially for relatively "large" blocks of HTML. And I personally don't like using globals. If my functions needs something I pass it - but that is more a coding style.

Well that is my $0.02. Take it or leave it. Oh and if you are really worried about speed - time your scripts with different variations. Then you will know if the script is the fastest it can be.

April 15th, 2005, 12:10 AM

Anonymous

Registered User

Codewalkers God 35th Plane (22000 - 22499 posts)

Join Date: Apr 2007

Posts: 22,309

Time spent in forums: < 1 sec
Reputation Power: 25

RE: Help 2 Optmize This Script!

I wouldnt call it exactly..speeding up your script, but cleaning it up may be a better word for it.

Take for instance this part:

php Code:

Original - php Code
echo ' <div align='center'> <table width=85%> <tr class='row1'>'; echo "<td background=$bgimg width=75%>";echo '<u>'.$GLOBALS['consolecolor'].' '; echo " $row2->name "; echo ' </font></u></td> </tr> <tr class='row2'> <td align='center'> ';

 
 
 echo '
                <div align='center'>
         <table width=85%>
          <tr class='row1'>';
           echo "<td background=$bgimg width=75%>";echo '<u>'.$GLOBALS['consolecolor'].' '; echo " $row2->name "; echo ' </font></u></td>
          </tr>
          <tr class='row2'>
            <td align='center'>
';

What I normally try to do, is keep all HTML stuff in one organized area. This can be accomplished as:

php Code:

Original - php Code
$_mydivide= <<<EOD <div align='center'> <table width=85%> <tr class='row1'> <td background=$bgimg width=75%><font>$_mystatement </font></u></td> </tr> <tr class='row2'> <td align='center'> EOD;

 
$_mydivide= <<<EOD
 <div align='center'>
         <table width=85%>
          <tr class='row1'>
          <td background=$bgimg width=75%><font>$_mystatement </font></u></td>
          </tr>
          <tr class='row2'>
            <td align='center'>
 
EOD;

Than, to call it all out, you could go about doing this:

php Code:

Original - php Code
$_mystatement="<u>'.$GLOBALS['consolecolor'].' $row2->name"; print("$_mydivide");

 
$_mystatement="<u>'.$GLOBALS['consolecolor'].' $row2->name";
print("$_mydivide");

Just with that tidbit, you can dramatically cut down your lines of code.
So, lets just apply that bit of it to your script.

php Code:

Original - php Code

 
 
    function dispConsole()
    {
             global $row1, $row2, $bgimg, $consolesep;
 
             {
            dispProfile();
    echo ' Welcome to Your Console '.$_SESSION['rank'].' '.$_SESSION['username'].'
            ';
    $result1=mysql_query("SELECT * FROM consoles WHERE minrank<= '".$_SESSION['rank']."' AND disabled=0  ORDER BY position ASC");
    while($row2 = mysql_fetch_object($result1)) {
 
//your statement can now be modified on the fly if need be
 
$_mystatement="<font><u>'.$GLOBALS['consolecolor'].' $row2->name</font></u>";
 
//here we have your table output
$_mydivide = <<<EOD
 <div align='center'>
         <table width=85%>
          <tr class='row1'>
          <td background=$bgimg width=75%>$_mystatement</td>
          </tr>
          <tr class='row2'>
            <td align='center'>
 
EOD;
 
// this prints out your information and table from one simple call line.
 
print("$_mydivide");
 
    $result = mysql_query("SELECT * FROM consolestuff WHERE minrank<= '".$_SESSION['rank']."' AND console ="$row2->name"");
 
    while($row3 = mysql_fetch_object($result)) {
 
    echo " $consolesep <a href=$row3->link> $row3->name</a> "; } echo '   $consolesep
      </td>
              </tr>
            </table>
            </div>
         ';
         //viewNews(1);
    }        } }
    ?>

Without knowing how this actually executes, or what info you pull up when running that script, it is possible that this will not work within the function guideline, however, it is the little tweaks like that above (and one could be made for your other echo statement as a link function) which keep (in my opinion anyway) things nice and easy to configure and edit down the road. Of course, a person could make one whole class out of that statement as well, but for now, as a function, it might do the trick.

Viewing: Codewalkers Forums > Other Technologies > Programming Theory > Help 2 Optmize This Script!

« Previous Thread | Next Thread »

Thread Tools	Search this Thread
Email this Page	Search this Thread: Advanced Search
Display Modes	Rate This Thread
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode	Rate This Thread:

Posting Rules
You may not post new threads You may not post replies You may not post attachments You may not edit your posts vB code is On Smilies are On [IMG] code is On HTML code is Off

View Your Warnings | New Posts | Latest News | Latest Threads | Shoutbox

Forum Jump

Free IT White Papers!

Create the Optimal Architecture for your Critical Applications
Warburton's the largest independently owned bakery in the UK faced a number of difficult challenges in providing the most robust yet efficient IT infrastructure for their organization's success. IBM's services combined with their xSeries servers created the perfect platform for their SAP environment with sufficient flexibility, and did so in very time effective fashion.
Request Your Free Technology Downloads!

Five Best Practices for Deploying a Successful Service-Oriented Architecture
This white paper describes the benefits you can expect with SOA, and how IBM can help take your business there.
Request Your Free Technology Downloads!

Gartner Magic Quadrant for Application Delivery Controllers
Gartner summarizes its view on Application Delivery Controllers, evaluates strengths and weaknesses of solutions, and provides Magic Quadrant reporting for a quick comparison across all vendors. Learn from Gartner how you can benefit from an all-in-one device like Citrix NetScaler that delivers the highest levels of availability, performance and security.
Request Your Free Technology Downloads!

Knowledge is Power
What you don't know can hurt you, and is likely costing you money and increasing your security risks during an era of scarce resources. This white paper proposes six key strategies that enterprise security managers can use to improve their network defense posture.
Request Your Free Technology Downloads!

Rationalizing the Multi-Tool Environment
The rationalized multi-tool approach is flexible, scalable and cost effective. It provides the necessary input to the IT service management business processes. It preserves prior investments in monitoring tools, empowers technologists to select the best tools with which to do their jobs, and enhances effective response to incidents.
Request Your Free Technology Downloads!

More Free IT White Papers!