This seems KLUNKY - Codewalkers

Codewalkers Forums Sponsor:

April 8th, 2005, 07:42 PM

LLX

Contributing User

Codewalkers Beginner (1000 - 1499 posts)

Join Date: Apr 2007

Location: Glendale, CA, USA

Posts: 1,121

Time spent in forums: 2 h 43 m 44 sec
Reputation Power: 3

This seems KLUNKY

http://domestic-staffingtimes.com/Ecard/cardindex.php

I got my display system to work but the menthod i used to get there seems klunky what with having to "force" the system to run invisible fetches to set the starting point, image the grin that would put on a topic 200 items big and you viewing the last page? 150 fetches is kinda insane and id love help to stream line it.

php Code:

Original - php Code

$result = mysql_query("SELECT * FROM cards");

$page = $_GET['page'];

// if a page isn't defined, we're on page one
if($page <= 0)
{
    $page = 1;
}

// where to start depending on what page we're viewing
$start = ($page * $display) - $display;

// how many lines of data to display
$display = 3;
$keys = mysql_num_rows($result);
//determine number of pages
$newspages = ($keys / $display);
$realstart = ($start + 1);
$finish = ($start + $display);
if ($finish > $keys) {
    $finish = $keys; }

//$news=mysql_fetch_assoc($result);
//$row = mysql_fetch_array($result);
//echo "<PRE>";
//print_r ($news);
//print_r ($row);
//echo "</PRE>";
// the actual news we're going to print

//KLUNKY way to set start point, HAS TO BE A BETTER WAY
$startpoint = $page-1;
 $startpoint = $startpoint * $display;

if ($page > 1){
for ($i = 1; $i <=  $startpoint; $i++){
$news=mysql_fetch_assoc($result);
}
}

echo '<table width="100%" border=1 cellpadding=4><TR>';
$Counter = 0;
for ($i = 1; $i <=  $display; $i++){
$news=mysql_fetch_assoc($result);
if ($Counter % 3 == 0){
echo '</TR><TR>';
}
if (trim($news)){
echo '<TD width=150 valign="top" align="center"><H1>ID: '.$news[ID].'</H1><BR><IMG SRC="'.$news[path].' height=150 width=150"><BR><H2>'.$news[name_card].'</H2></TD>';
} else {
echo '<TD width=150>&nbsp;</TD>';
}
$Counter++;
}
echo '</TR></table>';

/* old system, stil lseems superior if not perfect
echo '<table width="100%" border=1 cellpadding=4><TR>';
$Counter = 0;
while($news=mysql_fetch_assoc($result)) {
if ($Counter % 3 == 0){
echo '</TR><TR>';
}
echo '<TD width=150 valign="top" align="center"><H1>ID: '.$news[ID].'</H1><BR><IMG SRC="'.$news[path].' height=150 width=150"><BR><H2>'.$news[name_card].'</H2></TD>';
$Counter++;
}
while ($Counter % 3 != 0){
echo '<TD width=150>&nbsp;</TD>';
$Counter++;
}
echo '</TR></table>';
*/

//page display links
    echo '</table><table width="100%"><TR><TD align="left" width="50%">There are <B>' . $keys . '</B> ecards available.</TD>';
    echo '<TD align="right">You are on page: <b>' . $page . '</b> of <b>' . ceil($newspages) . '</b> Pages</TD></TR>';
    echo '<TR> <TD colspan="2" align="left">| ';
//previous link
if ($page > 1){
echo '<a href="'.$PHP_SELF.'?page='.($page-1).'">PREV</a> | ';
}
//page list
if ($newspages != (int) $newspages){

for ($pageslist = 1; $pageslist <= $newspages+1; $pageslist++){
	if ($pageslist != $page){
	echo '<a href="'.$PHP_SELF.'?page='.$pageslist.'">';
    	echo $pageslist . '</a> | ';
    } else {
    	echo '<B>'.$pageslist . '</B> | ';
    }
	}
} else {
	for ($pageslist = 1; $pageslist <= $newspages; $pageslist++){
	if ($pageslist != $page){
	echo '<a href="'.$PHP_SELF.'?page='.$pageslist.'">';
    	echo $pageslist . '</a> | ';
    } else {
    	echo '<B>'.$pageslist . '</B> | ';
    }
	}
}
//next link
if ($page != ceil($newspages)){
echo '<a href="'.$PHP_SELF.'?page='.($page+1).'">NEXT</a> |';
}

 
$result = mysql_query("SELECT * FROM cards");
 
$page = $_GET['page'];
 
// if a page isn't defined, we're on page one
if($page <= 0)
{
    $page = 1;
}
 
// where to start depending on what page we're viewing
$start = ($page * $display) - $display;
 
// how many lines of data to display
$display = 3;
$keys = mysql_num_rows($result);
//determine number of pages
$newspages = ($keys / $display);
$realstart = ($start + 1);
$finish = ($start + $display);
if ($finish > $keys) {
    $finish = $keys; }
 
//$news=mysql_fetch_assoc($result);
//$row = mysql_fetch_array($result);
//echo "<PRE>";
//print_r ($news);
//print_r ($row);
//echo "</PRE>";
// the actual news we're going to print
 
//KLUNKY way to set start point, HAS TO BE A BETTER WAY
$startpoint = $page-1;
 $startpoint = $startpoint * $display;
 
if ($page > 1){
for ($i = 1; $i <=  $startpoint; $i++){
$news=mysql_fetch_assoc($result);
}
}
 
echo '<table width="100%" border=1 cellpadding=4><TR>';
$Counter = 0;
for ($i = 1; $i <=  $display; $i++){
$news=mysql_fetch_assoc($result);
if ($Counter % 3 == 0){
echo '</TR><TR>';
}
if (trim($news)){
echo '<TD width=150 valign="top" align="center"><H1>ID: '.$news[ID].'</H1><BR><IMG SRC="'.$news[path].' height=150 width=150"><BR><H2>'.$news[name_card].'</H2></TD>';
} else {
echo '<TD width=150>&nbsp;</TD>';
}
$Counter++;
}
echo '</TR></table>';
 
/* old system, stil lseems superior if not perfect
echo '<table width="100%" border=1 cellpadding=4><TR>';
$Counter = 0;
while($news=mysql_fetch_assoc($result)) {
if ($Counter % 3 == 0){
echo '</TR><TR>';
}
echo '<TD width=150 valign="top" align="center"><H1>ID: '.$news[ID].'</H1><BR><IMG SRC="'.$news[path].' height=150 width=150"><BR><H2>'.$news[name_card].'</H2></TD>';
$Counter++;
}
while ($Counter % 3 != 0){
echo '<TD width=150>&nbsp;</TD>';
$Counter++;
}
echo '</TR></table>';
*/
 
//page display links
    echo '</table><table width="100%"><TR><TD align="left" width="50%">There are <B>' . $keys . '</B> ecards available.</TD>';
    echo '<TD align="right">You are on page: <b>' . $page . '</b> of <b>' . ceil($newspages) . '</b> Pages</TD></TR>';
    echo '<TR> <TD colspan="2" align="left">| ';
//previous link
if ($page > 1){
echo '<a href="'.$PHP_SELF.'?page='.($page-1).'">PREV</a> | ';
}
//page list
if ($newspages != (int) $newspages){
 
    for ($pageslist = 1; $pageslist <= $newspages+1; $pageslist++){
    if ($pageslist != $page){
    echo '<a href="'.$PHP_SELF.'?page='.$pageslist.'">';
        echo $pageslist . '</a> | ';
    } else {
        echo '<B>'.$pageslist . '</B> | ';
    }
    }
} else {
    for ($pageslist = 1; $pageslist <= $newspages; $pageslist++){
    if ($pageslist != $page){
    echo '<a href="'.$PHP_SELF.'?page='.$pageslist.'">';
        echo $pageslist . '</a> | ';
    } else {
        echo '<B>'.$pageslist . '</B> | ';
    }
    }
}
//next link
if ($page != ceil($newspages)){
echo '<a href="'.$PHP_SELF.'?page='.($page+1).'">NEXT</a> |';
}

April 9th, 2005, 05:29 AM

spud

Join Date: Apr 2007

Location: Melbourne, Australia

Posts: 163

Time spent in forums: < 1 sec
Reputation Power: 2

RE: This seems KLUNKY

i've probably misunderstood your question, but it sounds like you want pagination...

http://codewalkers.com/tutorials/4/1.html

have a look at that.

sorry if that wasn't at all helpful

April 9th, 2005, 04:20 PM

LLX

Contributing User

Join Date: Apr 2007

Location: Glendale, CA, USA

Posts: 1,121

Time spent in forums: 2 h 43 m 44 sec
Reputation Power: 3

RE: This seems KLUNKY

i have pagination working the problem i s that in order to set the start point i need to do a invisible fetch of my database array and ifi its a large one that a lot of fetching

April 10th, 2005, 02:42 AM

spud

Join Date: Apr 2007

Location: Melbourne, Australia

Posts: 163

Time spent in forums: < 1 sec
Reputation Power: 2

RE: This seems KLUNKY

have a look at LIMITS.
i can't remember the exact syntax, but it'd be something like

php Code:

Original - php Code
$page = $_GET['page']; if($page <= 0) { $page = 1; } $display = 3; $start = ($page * $display) - $display; $result = mysql_query("SELECT * FROM cards LIMIT ".$start.",".$display);

 
$page = $_GET['page'];
if($page <= 0)
{
    $page = 1;
}
 
$display = 3;
$start = ($page * $display) - $display;
 
$result = mysql_query("SELECT * FROM cards LIMIT ".$start.",".$display);

April 10th, 2005, 02:06 PM

System

Join Date: Apr 2007

Posts: 665

Time spent in forums: < 1 sec
Reputation Power: 2

Message Moved

Thread moved from 'PHP Coding' to 'Programming Theory' by andrew.

Reason:

April 11th, 2005, 04:33 PM

LLX

Contributing User

Join Date: Apr 2007

Location: Glendale, CA, USA

Posts: 1,121

Time spent in forums: 2 h 43 m 44 sec
Reputation Power: 3

RE: This seems KLUNKY

i had to modify the code a bit to fit the rules of limit

FYI its

$result = mysql_query("SELECT * FROM cards LIMIT $start, $display");

not

$result = mysql_query("SELECT * FROM cards LIMIT ".$start.", ".$display.");

http://domestic-staffingtimes.com/Ecard/cardindex.php?page=2

however the limit works to well, when you click on another page it still uses the original limits, it does see mto update the limits for the next bock of data

the second part seems to work displaying only $display values its the first part that seems to not work it seems to only start at page 1

php Code:

Original - php Code

$page = $_GET['page'];

// if a page isn't defined, we're on page one
if($page <= 0)
{
    $page = 1;
}

// where to start depending on what page we're viewing
$start = ($page * $display) - $display;
// how many lines of data to display
$display = 6;

$resultfull = mysql_query("SELECT * FROM cards");
$result = mysql_query("SELECT * FROM cards LIMIT $start, $display");
$keys = mysql_num_rows($resultfull);
$newspages = ($keys / $display);

//determine number of pages
$realstart = ($start + 1);
$finish = ($start + $display);
if ($finish > $keys) {
    $finish = $keys; }

//$news=mysql_fetch_assoc($result);
//$row = mysql_fetch_array($result);
//echo "<PRE>";
//print_r ($news);
//print_r ($row);
//echo "</PRE>";
// the actual news we're going to print

echo '<table width="100%" border=1 cellpadding=4><TR>';
$Counter = 0;
while ($news=mysql_fetch_assoc($result)){
if ($Counter % 3 == 0){
echo '</TR><TR>';
}
if (trim($news)){
echo '<TD width=200 valign="top" align="center"><H1>ID: '.$news[ID].'</H1><BR><a href="makecard.php?image='.$news[ID].'"><IMG SRC="'.$news[path].'" height=150 width=200 border=0></a><BR><H2>'.$news[name_card].'</H2><BR>
Click the image to use it as your ecard</TD>';
} else {
echo '<TD width=200>&nbsp;</TD>';
}
$Counter++;
}
echo '</TR></table>';

 
 
$page = $_GET['page'];
 
// if a page isn't defined, we're on page one
if($page <= 0)
{
    $page = 1;
}
 
// where to start depending on what page we're viewing
$start = ($page * $display) - $display;
// how many lines of data to display
$display = 6;
 
$resultfull = mysql_query("SELECT * FROM cards");
$result = mysql_query("SELECT * FROM cards LIMIT $start, $display");
$keys = mysql_num_rows($resultfull);
$newspages = ($keys / $display);
 
//determine number of pages
$realstart = ($start + 1);
$finish = ($start + $display);
if ($finish > $keys) {
    $finish = $keys; }
 
//$news=mysql_fetch_assoc($result);
//$row = mysql_fetch_array($result);
//echo "<PRE>";
//print_r ($news);
//print_r ($row);
//echo "</PRE>";
// the actual news we're going to print
 
echo '<table width="100%" border=1 cellpadding=4><TR>';
$Counter = 0;
while ($news=mysql_fetch_assoc($result)){
if ($Counter % 3 == 0){
echo '</TR><TR>';
}