News System Part 2 (Edit/Delete Function Not Working)

Codewalkers Forums Sponsor:

Stay one step ahead of the competition. Evaluate and give feedback on some of the hottest web development tools on the market today. Make your opinion heard! Click Here

March 29th, 2004, 03:09 PM

zipperlip

Join Date: Apr 2007

Location: Kirkland, Wa

Posts: 2

Time spent in forums: < 1 sec
Reputation Power: 0

News System Part 2 (Edit/Delete Function Not Working)

I have been looking through the code and I cannot find 2 things.

1) The script does not allow editing or deleting of the data file.

I copied the code as it is on the site (thank you Matt), and everything but edit/delete works fine.

If you can help, I would REALLY appreciate it!

php Code:

Original - php Code

<?
if($action == "edit" && isset($HTTP_POST_VARS['password'])) {
    if($HTTP_POST_VARS['password'] == "<password>") {
        $line = $HTTP_POST_VARS['date'] . "|" . $HTTP_POST_VARS['name'];
        $line .= "|" . $HTTP_POST_VARS['news'];
        $line = str_replace("rn","<BR>",$line);
        $line .= "rn";
        $data = file('news.txt');
        $data[$id] = $line;
        reset($data);
        $fp = fopen('news.txt','w');
        foreach($data as $element) {
            fwrite($fp, $element);
        }
        fclose($fp);
        echo "Item Edited!<BR><BR>n";
        echo "<a href="$PHP_SELF">Go Back</a>n";
        exit;
    } else {
        echo "Bad password!n";
        exit;
    }
}
if($action == "edit") {
    $data = file('news.txt');
    $element = trim($data[$id]);
    $pieces = explode("|", $element);
    $news = str_replace("<BR>","rn",$pieces[2]);
    echo "Make the changes you would like and press save.<BR>n";
    echo "<FORM ACTION="$PHP_SELF?action=edit" METHOD="POST" NAME="editform">n";
    echo "Name:<BR>n";
    echo "<INPUT TYPE="text" SIZE="30" NAME="name" value="".$pieces[1].""><BR>n";
    echo "The News:<BR>n";
    echo "<TEXTAREA NAME="news" COLS="40" ROWS="5">".$news."</TEXTAREA><BR><BR>n";
    echo "Password:<BR>n";
    echo "<INPUT TYPE="password" SIZE="30" NAME="password"><BR>n";
    echo "<INPUT TYPE="hidden" NAME="date" VALUE="".$pieces[0]."">n";
    echo "<INPUT TYPE="hidden" NAME="id" VALUE="$id">n";
    echo "<INPUT TYPE="submit" NAME="submit" VALUE="Save"><BR>n";
    echo "</FORM>n";
    exit;
}
if($action == "delete" && isset($HTTP_POST_VARS['password'])) {
    if($HTTP_POST_VARS['password'] == "<password>") {
        $data = file('news.txt');
        array_splice($data,$id,1);
        $fp = fopen('news.txt','w');
        foreach($data as $element) {
            fwrite($fp, $element);
        }
        fclose($fp);    
        echo "Item deleted!<BR><BR>n";    
        echo "<a href="$PHP_SELF">Go Back</a>n";
        exit;
    } else {
        echo "Bad password!n";
        exit;
    }
}
if($action == "delete") {
    echo "<H2>You are about to delete the following news item.</H2>n";
    $data = file('news.txt');
    $element = trim($data[$id]);
    $pieces = explode("|", $element);
    echo $pieces[2] . "<BR>" . "<b>Posted by " . $pieces[1] . " on " . $pieces[0] . "</b>n";
    echo "<BR><BR>n";
    echo "Are you sure you want to delete this news item? If so, enter the password and click on Delete.<BR>n";
    echo "<FORM ACTION="$PHP_SELF?action=delete" METHOD="POST" NAME="deleteform">n";
    echo "Password:<BR>n";
    echo "<INPUT TYPE="password" SIZE="30" NAME="password"><BR>n";
    echo "<INPUT TYPE="hidden" NAME="id" VALUE="$id">n";
    echo "<INPUT TYPE="submit" NAME="submit" VALUE="Delete"><BR>n";
    echo "</FORM>n";
    exit;
}

echo "<H1><u>Current News</u></H1>n";
$data = file('news.txt');
$data = array_reverse($data);
foreach($data as $key=>$element) {
    $element = trim($element);
    $pieces = explode("|", $element);
    echo $pieces[2] . "<BR>" . "<b>Posted by " . $pieces[1] . " on " . $pieces[0] . "</b>n";
    echo "&nbsp;<a href="$PHP_SELF?action=delete&id=$key">Delete</a>n";
    echo "&nbsp;<a href="$PHP_SELF?action=edit&id=$key">Edit</a>n";
    echo "<BR><BR>n";
}
echo "<HR>n";
echo "<H1><u>Add News</u></H1>n";
if($HTTP_POST_VARS['submit']) {
    if($HTTP_POST_VARS['password'] == '<password>') {
        if(!$HTTP_POST_VARS['name']) {
            echo "You must enter a name";
            exit;
        }
        if(!$HTTP_POST_VARS['news']) {
            echo "You must enter some news";
            exit;
        }
        if(strstr($HTTP_POST_VARS['name'],"|")) {
            echo "Name cannot contain the pipe symbol - |";
            exit;
        }
        if(strstr($HTTP_POST_VARS['news'],"|")) {
            echo "News cannot contain the pipe symbol - |";
            exit;
        }
        $fp = fopen('news.txt','a');
        if(!$fp) {
            echo "Error opening file!";
            exit;
        }
        $line = date("m.d.y") . "|" . $HTTP_POST_VARS['name'];
        $line .= "|" . $HTTP_POST_VARS['news'];
        $line = str_replace("rn","<BR>",$line);
        $line .= "rn";
        fwrite($fp, $line);
        if(!fclose($fp)) {
            echo "Error closing file!";
            exit;
        }
        echo "<b>News added!</b>n";    
    } else {
        echo "Bad Password";
    }
}

?>
<FORM ACTION="<?=$PHP_SELF?>" METHOD="POST" NAME="newsentry">
Your name:<BR>
<INPUT TYPE="text" SIZE="30" NAME="name"><BR>
The News:<BR>
<TEXTAREA NAME="news" COLS="40" ROWS="5"></TEXTAREA><BR><BR>
News Password:<BR>
<INPUT TYPE="password" SIZE="30" NAME="password"><BR>
<INPUT TYPE="submit" NAME="submit" VALUE="Post it!"><BR>
</FORM>

 
<?
if($action == "edit" && isset($HTTP_POST_VARS['password'])) {
    if($HTTP_POST_VARS['password'] == "<password>") {
        $line = $HTTP_POST_VARS['date'] . "|" . $HTTP_POST_VARS['name'];
        $line .= "|" . $HTTP_POST_VARS['news'];
        $line = str_replace("rn","<BR>",$line);
        $line .= "rn";
        $data = file('news.txt');
        $data[$id] = $line;
        reset($data);
        $fp = fopen('news.txt','w');
        foreach($data as $element) {
            fwrite($fp, $element);
        }
        fclose($fp);
        echo "Item Edited!<BR><BR>n";
        echo "<a href="$PHP_SELF">Go Back</a>n";
        exit;
    } else {
        echo "Bad password!n";
        exit;
    }
}
if($action == "edit") {
    $data = file('news.txt');
    $element = trim($data[$id]);
    $pieces = explode("|", $element);
    $news = str_replace("<BR>","rn",$pieces[2]);
    echo "Make the changes you would like and press save.<BR>n";
    echo "<FORM ACTION="$PHP_SELF?action=edit" METHOD="POST" NAME="editform">n";
    echo "Name:<BR>n";
    echo "<INPUT TYPE="text" SIZE="30" NAME="name" value="".$pieces[1].""><BR>n";
    echo "The News:<BR>n";
    echo "<TEXTAREA NAME="news" COLS="40" ROWS="5">".$news."</TEXTAREA><BR><BR>n";
    echo "Password:<BR>n";
    echo "<INPUT TYPE="password" SIZE="30" NAME="password"><BR>n";
    echo "<INPUT TYPE="hidden" NAME="date" VALUE="".$pieces[0]."">n";
    echo "<INPUT TYPE="hidden" NAME="id" VALUE="$id">n";
    echo "<INPUT TYPE="submit" NAME="submit" VALUE="Save"><BR>n";
    echo "</FORM>n";
    exit;
}
if($action == "delete" && isset($HTTP_POST_VARS['password'])) {
    if($HTTP_POST_VARS['password'] == "<password>") {
        $data = file('news.txt');
        array_splice($data,$id,1);
        $fp = fopen('news.txt','w');
        foreach($data as $element) {
            fwrite($fp, $element);
        }
        fclose($fp);    
        echo "Item deleted!<BR><BR>n";    
        echo "<a href="$PHP_SELF">Go Back</a>n";
        exit;
    } else {
        echo "Bad password!n";
        exit;
    }
}
if($action == "delete") {
    echo "<H2>You are about to delete the following news item.</H2>n";
    $data = file('news.txt');
    $element = trim($data[$id]);
    $pieces = explode("|", $element);
    echo $pieces[2] . "<BR>" . "<b>Posted by " . $pieces[1] . " on " . $pieces[0] . "</b>n";
    echo "<BR><BR>n";
    echo "Are you sure you want to delete this news item? If so, enter the password and click on Delete.<BR>n";
    echo "<FORM ACTION="$PHP_SELF?action=delete" METHOD="POST" NAME="deleteform">n";
    echo "Password:<BR>n";
    echo "<INPUT TYPE="password" SIZE="30" NAME="password"><BR>n";
    echo "<INPUT TYPE="hidden" NAME="id" VALUE="$id">n";
    echo "<INPUT TYPE="submit" NAME="submit" VALUE="Delete"><BR>n";
    echo "</FORM>n";
    exit;
}
 
 
echo "<H1><u>Current News</u></H1>n";
$data = file('news.txt');
$data = array_reverse($data);
foreach($data as $key=>$element) {
    $element = trim($element);
    $pieces = explode("|", $element);
    echo $pieces[2] . "<BR>" . "<b>Posted by " . $pieces[1] . " on " . $pieces[0] . "</b>n";
    echo "&nbsp;<a href="$PHP_SELF?action=delete&id=$key">Delete</a>n";
    echo "&nbsp;<a href="$PHP_SELF?action=edit&id=$key">Edit</a>n";
    echo "<BR><BR>n";
}
echo "<HR>n";
echo "<H1><u>Add News</u></H1>n";
if($HTTP_POST_VARS['submit']) {
    if($HTTP_POST_VARS['password'] == '<password>') {
        if(!$HTTP_POST_VARS['name']) {
            echo "You must enter a name";
            exit;
        }
        if(!$HTTP_POST_VARS['news']) {
            echo "You must enter some news";
            exit;
        }
        if(strstr($HTTP_POST_VARS['name'],"|")) {
            echo "Name cannot contain the pipe symbol - |";
            exit;
        }
        if(strstr($HTTP_POST_VARS['news'],"|")) {
            echo "News cannot contain the pipe symbol - |";
            exit;
        }
        $fp = fopen('news.txt','a');
        if(!$fp) {
            echo "Error opening file!";
            exit;
        }
        $line = date("m.d.y") . "|" . $HTTP_POST_VARS['name'];
        $line .= "|" . $HTTP_POST_VARS['news'];
        $line = str_replace("rn","<BR>",$line);
        $line .= "rn";
        fwrite($fp, $line);
        if(!fclose($fp)) {
            echo "Error closing file!";
            exit;
        }
        echo "<b>News added!</b>n";    
    } else {
        echo "Bad Password";
    }
}
 
?>
<FORM ACTION="<?=$PHP_SELF?>" METHOD="POST" NAME="newsentry">
Your name:<BR>
<INPUT TYPE="text" SIZE="30" NAME="name"><BR>
The News:<BR>
<TEXTAREA NAME="news" COLS="40" ROWS="5"></TEXTAREA><BR><BR>
News Password:<BR>
<INPUT TYPE="password" SIZE="30" NAME="password"><BR>
<INPUT TYPE="submit" NAME="submit" VALUE="Post it!"><BR>
</FORM>

March 30th, 2004, 12:13 AM

System

Join Date: Apr 2007

Posts: 665

Time spent in forums: < 1 sec
Reputation Power: 2

Message Moved

Thread moved from 'PHP Coding' to 'Tutorials' by sliver.

Reason:

March 30th, 2004, 06:52 PM

The Squirrel

Join Date: Apr 2007

Location: Mid-Indiana, USA

Posts: 153

Time spent in forums: < 1 sec
Reputation Power: 2

RE: Message Moved

Is register globals turned on or off in your PHP.ini file?

Have you tried changing all the $HTTP_POST_VARS to just $_POST? Try this and come back if it still does not work. I know this was a problem when I first started working on a similar script.

The Squirrel

Thread Tools	Search this Thread
Email this Page	Search this Thread: Advanced Search
Display Modes	Rate This Thread
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode	Rate This Thread: